Skip to content

Commit

Permalink
imp(with_defaults): Deprecate App::with_defaults()
Browse files Browse the repository at this point in the history
Following the discussion on #638 a consensus that it can never work
(and was a mistake in the first place) has been reached

Closes #638
  • Loading branch information
nabijaczleweli committed Oct 16, 2016
1 parent 47ffccd commit 2608540
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/app/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ impl<'a, 'b> App<'a, 'b> {
/// [`crate_version!`]: ./macro.crate_version!.html
/// [`App::author`]: ./struct.App.html#method.author
/// [`App::version`]: ./struct.App.html#method.author
#[deprecated(since="2.14.1", note="Can never work; use explicit App::author() and App::version() calls instead")]
pub fn with_defaults<S: Into<String>>(n: S) -> Self {
let mut a = App { p: Parser::with_name(n.into()) };
a.p.meta.author = Some(crate_authors!());
Expand Down

0 comments on commit 2608540

Please sign in to comment.