Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color should be exposed as a single enum, not individual Settings #2811

Closed
epage opened this issue Oct 4, 2021 · 2 comments · Fixed by #2851
Closed

Color should be exposed as a single enum, not individual Settings #2811

epage opened this issue Oct 4, 2021 · 2 comments · Fixed by #2851
Assignees
Labels
A-builder Area: Builder API C-bug Category: Updating dependencies M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Milestone

Comments

@epage
Copy link
Member

epage commented Oct 4, 2021

Rust Version

1.55.0

Affected Version of clap

v3.0.0-beta.4

Expected Behavior Summary

Color should be 1 enum

Actual Behavior Summary

It is three settings, one for each variant

@epage epage added C-bug Category: Updating dependencies M-breaking-change Meta: Implementing or merging this will introduce a breaking change. A-builder Area: Builder API D: easy labels Oct 4, 2021
@epage epage added this to the 4.0 milestone Oct 4, 2021
@pksunkara
Copy link
Member

Can we move this to v3? All the weird settings have been cleaned up except for this. (One of the main objective for v3).

@epage
Copy link
Member Author

epage commented Oct 9, 2021

Its really tempting to say yes but there will always be yet another thing and its easy to underestimate the amount of polish needed for that next thing.

I suggest we focus on polishing what we've done and do this soon after. If we move forward with #2718, then we can start this in 3.x.

With that said, I do not see our milestones as prescriptive but focus areas. However, work done by somebody outside of a focus area should be the level of quality and lack of debate to not detract others from the focus areas.

Speaking of, "focus areas" is a model I've taken in one my projects. Instead of release milestones, I have a project board with "Triage", "Focus", "Planned", and "Someday". Works well for me. Release milestones would still be useful to track more explicit blockers, like regressions from within the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builder Area: Builder API C-bug Category: Updating dependencies M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants