Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output when multicall applet isn't found is unhelpful and ugly #2862

Closed
Tracked by #215
, #2861
...
fishface60 opened this issue Oct 12, 2021 · 0 comments
Closed
Tracked by #215
, #2861
...

Output when multicall applet isn't found is unhelpful and ugly #2862

fishface60 opened this issue Oct 12, 2021 · 0 comments
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-enhancement Category: Raise on the bar on expectations S-waiting-on-mentor Status: Needs elaboration on the details before doing a 'Call for participation'

Comments

@fishface60
Copy link
Contributor

Affected Version of clap

  • 3.0.0-beta.4

Expected Behavior Summary

When I run a multicall program from a link that does not match an applet, I expect an error message explaining that the applet was not found and which applets exist.

Actual Behavior Summary

Error message just lists that the argument wasn't expected.

Steps to Reproduce the issue

$ cargo build --examples
$ ln target/debug/examples/24_multicall_busybox asdf
$ ./asdf 
error: Found argument 'asdf' which wasn't expected, or isn't valid in this context

USAGE:
     [SUBCOMMAND]

For more information try --help
@pksunkara pksunkara added C-enhancement Category: Raise on the bar on expectations C: errors labels Oct 12, 2021
@fishface60 fishface60 mentioned this issue Oct 12, 2021
Closed
7 tasks
This was referenced Dec 6, 2021
Open
Open
@fishface60 fishface60 mentioned this issue Dec 8, 2021
Merged
@epage epage added A-parsing Area: Parser's logic and needs it changed somehow. S-waiting-on-mentor Status: Needs elaboration on the details before doing a 'Call for participation' and removed C: errors labels Dec 8, 2021
epage added a commit to epage/clap that referenced this issue May 2, 2022
@epage
fix(multicall): Improve bad multicall binary error
414ae57 
By removing all arguments, we've switched from an "unrecognized
argument" error to a "unrecognized subcommand" error.  While the wording
has room for improvement, its at least progress on clap-rs#2862.
@epage epage mentioned this issue May 2, 2022
Merged
@epage epage closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-enhancement Category: Raise on the bar on expectations S-waiting-on-mentor Status: Needs elaboration on the details before doing a 'Call for participation'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@epage @pksunkara @fishface60