Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove Parser::update_from? #4974

Open
epage opened this issue Jun 19, 2023 · 1 comment
Open

Deprecate and remove Parser::update_from? #4974

epage opened this issue Jun 19, 2023 · 1 comment
Labels
A-derive Area: #[derive]` macro API C-enhancement Category: Raise on the bar on expectations S-triage Status: New; needs maintainer attention.

Comments

@epage
Copy link
Member

epage commented Jun 19, 2023

Parser::update_from and related functions were introduced into the derive API in clap v3 (ie they didn't exist in structopt). They required a lot of work to get the basic semantics down for 3.0.0 (#2212, #2605) and since have continued to have issues for it (#4501, #4617, see also #3924).

However, it does seem like this does not have impact on build time or binary size which I had assumed it would.

@epage epage added C-enhancement Category: Raise on the bar on expectations A-derive Area: #[derive]` macro API S-triage Status: New; needs maintainer attention. labels Jun 19, 2023
epage added a commit to epage/clap that referenced this issue Jun 19, 2023
@epage
Copy link
Member Author

epage commented Jun 19, 2023

#4975 is the branch I used for testing binary size and build time of --example git-derive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: #[derive]` macro API C-enhancement Category: Raise on the bar on expectations S-triage Status: New; needs maintainer attention.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant