Test for Issue 1135 #1136
Merged
Test for Issue 1135 #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like required_unless_one has incorrect behavior if the argument it applies to also has a short form.
|
@willmurphyscode, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer. |
Flags were incorrectly reporting that they never had required_unless args.
willmurphyscode
commented
Jan 19, 2018
| @@ -67,7 +67,7 @@ impl<'n, 'e> AnyArg<'n, 'e> for FlagBuilder<'n, 'e> { | |||
| self.b.requires.as_ref().map(|o| &o[..]) | |||
| } | |||
| fn blacklist(&self) -> Option<&[&'e str]> { self.b.blacklist.as_ref().map(|o| &o[..]) } | |||
| fn required_unless(&self) -> Option<&[&'e str]> { None } | |||
| fn required_unless(&self) -> Option<&[&'e str]> { self.b.r_unless.as_ref().map(|o| &o[..]) } | |||
There was a problem hiding this comment.
This line is copied from the analogous line in the Positional arg builder: https://github.com/kbknapp/clap-rs/blob/f85fd9fbc8a1b2f5f319dad272405ac8e43c790f/src/args/arg_builder/positional.rs#L141 - I assume that the logic is supposed to be the same for both types of args.
|
Nice, good catch! Thanks @willmurphyscode 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
required_unless_onehas incorrect behavior if theargument it applies to also has a short form. This adds a failing test, but I could use help fixing the issue.
This change is