Fix benchmarks #1698
Merged
Fix benchmarks #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you working on making them use criterion? |
|
Nope, not yet. I'll get to it the day after tomorrow. |
|
I can work on this if you are busy. |
|
I was, but I'm getting to it in several hours. |
CreepySkeleton
force-pushed
the
fix_benches
branch
from
e64635f
to
b5994d1
Compare
|
Rebased on top of #1700 , will need to merge that first. All of the benches are moved to criterion, but, quite frankly, most of them are useless. I'm plaiyng with them to figure out which. |
CreepySkeleton
force-pushed
the
fix_benches
branch
from
b5994d1
to
ef280c8
Compare
pksunkara
requested changes
Feb 21, 2020
CreepySkeleton
force-pushed
the
fix_benches
branch
from
ef280c8
to
57ca488
Compare
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.