Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #1622 #1732

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Fixed #1622 #1732

merged 2 commits into from
Mar 8, 2020

Conversation

sphinxc0re
Copy link
Contributor

Closes #1622

@sphinxc0re
Copy link
Contributor Author

sphinxc0re commented Mar 8, 2020 •
edited

@pksunkara I'll probably need some pointers

@pksunkara
Copy link
Member

Can you please add a test?

@sphinxc0re
Copy link
Contributor Author

Sure

@sphinxc0re
Copy link
Contributor Author

I'm a little bit lost here. I never worked on this project before. What do I have to do to make this benchmark thing work?

@CreepySkeleton
Copy link
Contributor

@sphinxc0re I suspect it's broken. Don't think about it.

@pksunkara
Copy link
Member

Github Action doesn't seem to run for external PRs.

@pksunkara
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 8, 2020

Build succeeded

@bors bors bot merged commit 2370665 into clap-rs:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting Flags Error message contains the same flag twice
3 participants
@sphinxc0re @pksunkara @CreepySkeleton