fix(clap_derive): Unwrap syn::TypeGroup when checking field types
#1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to macro expansions, a `syn` type may be wrapped in multiple 'layers' of `syn::Type::Group`. However, `clap_derive` currently does not check for `syn::Type::Group`, which will cause an `Option` (along with other matched types) to fail to be detected when it results from a macro expansion. This commit 'unwraps' outer type groups before checking the user-provided types against well-known types. Currently, these groups may not be present due to a rustc bug (rust-lang/rust#43081) However, once rust-lang/rust#73084 is merged, these groups will be present in more cases. This commit makes `clap` compatible with both older and newer versions of rustc.
Aaron1011
force-pushed
the
fix/type-group
branch
from
0c3cf84
to
c837b28
Compare
|
bors r+ Thank you, @Aaron1011 ! |
|
Build succeeded: |
|
@CreepySkeleton: Could you make a new point release? That will make it easy for any crates broken by rust-lang/rust#73084 to keep compiling. |
|
This branch is still in beta, we can't do a patch release. |
|
@pksunkara Why exactly we can't have a new |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to macro expansions, a
syntype may be wrapped in multiple'layers' of
syn::Type::Group. However,clap_derivecurrently doesnot check for
syn::Type::Group, which will cause anOption(alongwith other matched types) to fail to be detected when it results from a
macro expansion.
This commit 'unwraps' outer type groups before checking the
user-provided types against well-known types. Currently, these groups
may not be present due to a rustc bug (rust-lang/rust#43081)
However, once rust-lang/rust#73084 is merged,
these groups will be present in more cases. This commit makes
clapcompatible with both older and newer versions of rustc.