feat(derive): Make it possible to use ArgEnum with default_value #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
requested changes
Jul 25, 2021
| /// The canonical argument value. | ||
| /// | ||
| /// The value is `None` for skipped variants. | ||
| fn as_arg(&self) -> Option<&'static str>; |
There was a problem hiding this comment.
Isn't it better called as to_string or something similar? strum does something similar. https://docs.rs/strum/0.21.0/strum/derive.ToString.html
There was a problem hiding this comment.
- That trait allocates
- I wanted to be clear that this conversion was to the raw argument value and not a general string conversion, which is why
skiped values are not covered. People may choose to implement other traits, likeDisplayorToStringon top of this though they have to panic or have a sentinel value when rendering a skipped value.
This doesn't solve the problem end-to-end but at least makes it possible to solve by the user and improve in the future.
pksunkara
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't solve the problem end-to-end but at least makes it possible
to solve by the user and improve in the future.