fix(generate): Better subcommand completion in fish #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModProg
force-pushed
the
fish-better-subcommands
branch
from
a76f343
to
7c6b362
Compare
|
Need to update the tests |
ModProg
force-pushed
the
fish-better-subcommands
branch
2 times, most recently
from
d802c56
to
d6cd435
Compare
* Prevent completing subcommands that were already completed * Make sure all parent subcommands actually existent Partially fixes clap-rs#2715
ModProg
force-pushed
the
fish-better-subcommands
branch
from
d6cd435
to
0ba508a
Compare
pksunkara
requested changes
Sep 8, 2021
This now also disables the completion of sub_subcommands options for subcommands.
pksunkara
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially does a bit of #2715 (the "simple case")