docs: Encourage multiple_occurrences #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were fewer occasions than I expected where the use of `multiple_values` was superfluous and we could instead use the more predictable `multiple_occurrences`. In terms of the remaining `multiple` split work, clap-rs#1772 will take care of the derive behavior and clap-rs#2692 will resolve any remaining issues with values vs occurrences in positional arguments. Fixes clap-rs#2816
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were fewer occasions than I expected where the use of
multiple_valueswas superfluous and we could instead use the morepredictable
multiple_occurrencesIn terms of the remaining
multiplesplit work, #1772 will take care of the derivebehavior and #2692 will resolve any remaining issues with values vs
occurrences in positional arguments.
Fixes #2816