Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): Fix many typos in docs, comments and codes found by typos-cli #2909

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Oct 19, 2021

I found checking typos included in tasks for 3.0 release at #2869. To help the release go forward, I ran typos-cli locally and fixed all typos found by it avoiding false positives.

Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 19, 2021
2909: feat(doc): Fix many typos in docs, comments and codes found by typos-cli r=pksunkara a=rhysd



Co-authored-by: rhysd <lin90162@yahoo.co.jp>
@bors
Copy link
Contributor

bors bot commented Oct 19, 2021

Build failed:

@rhysd
Copy link
Contributor Author

rhysd commented Oct 19, 2021

I don't have permission to check bors's CI result. Would you tell me what failed? As far as I ran tests on my local machine, all passed successfully. I'm sorry that I'm not understanding what is checked by the bors checker.

@rhysd
Copy link
Contributor Author

rhysd commented Oct 19, 2021

I also fixed some clippy warnings.

@pksunkara
Copy link
Member

bors r+

It was just a bad startup process. You could see it on github actions, https://github.com/clap-rs/clap/runs/3934111951

@bors
Copy link
Contributor

bors bot commented Oct 19, 2021

Build succeeded:

@bors bors bot merged commit fe29af7 into clap-rs:master Oct 19, 2021
@rhysd
Copy link
Contributor Author

rhysd commented Oct 19, 2021

ok, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants