Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site cookbook examples #3058

Closed

Conversation

coffeeplease61
Copy link

Hi, i saw the cookbook page for what appears to be clap's official site was empty.

referencing the examples/ dir, i added some detail for a basic application and some links directing anyone who might end up there to more info.

attached are some screens of the markdown.

please review

also thanks so much for this awesome package

Screen Shot 2021-12-03 at 5 26 35 PM
Screen Shot 2021-12-03 at 5 26 14 PM
Screen Shot 2021-12-03 at 5 25 55 PM

Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a lot of unnecessary file permissions changes in this PR..

Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this is not what a cookbook is planned to be. It is supposed to be a list of detailed tutorials and everyday use cases.

@coffeeplease61
Copy link
Author

@pksunkara ok np then i can close

@pksunkara
Copy link
Member

@c0ffeep1s I really welcome your enthusiasm though. Maybe you will have a better idea on what docs to help with once we have a small example of the cookbook up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants