Fix unqualified result types causing compilation failures with derive implementations #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
requested changes
Dec 10, 2021
spire-ffoston
force-pushed
the
fix-result-type-alias-derive-impl
branch
from
e3f80f6
to
746ff3e
Compare
…e implementations
spire-ffoston
force-pushed
the
fix-result-type-alias-derive-impl
branch
from
746ff3e
to
1285c0f
Compare
pksunkara
approved these changes
Dec 10, 2021
|
Thanks! I had been considering adding a test like that. |
epage
added a commit
to epage/clap
that referenced
this pull request
Jun 13, 2022
With the new `ArgMatches`, we need to know what the inner type is. Unfortunately, clap-rs#3142 didn't list use cases for this. We dropped the `Option` alias changing `T` but we still have a `Result` in there that is aliased. One potential workaround if people need it is if we add an attribute to specify the `get_many::<T>` type. This would also help with `ArgAction::Count` to support more data types.
epage
added a commit
to epage/clap
that referenced
this pull request
Jun 14, 2022
With the new `ArgMatches`, we need to know what the inner type is. Unfortunately, clap-rs#3142 didn't list use cases for this. We dropped the `Option` alias changing `T` but we still have a `Result` in there that is aliased. One potential workaround if people need it is if we add an attribute to specify the `get_many::<T>` type. This would also help with `ArgAction::Count` to support more data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some additional unqualified types in the derive macros and adds a regression test case.