Added basic argument ordering to clap_man #3373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Jan 31, 2022
epage
reviewed
Jan 31, 2022
epage
reviewed
Jan 31, 2022
epage
added
the
S-waiting-on-author
|
I updated as suggested, utilising display order, followed by an alphabetical ordering for options with equal display order. |
epage
reviewed
Feb 6, 2022
|
Looks like this needs to be rebased |
|
btw #3544 switched how we test |
ducaale
added a commit
to ducaale/xh
that referenced
this pull request
Sep 11, 2022
Otherwise, the order of arguments changes, which AFAIK is not resettable. Also, see clap-rs/clap#3373 which exposes an internal method for reading derived order values for arguments.
|
@cgubbin do you plan to get back to this PR or should we close it? |
|
As its been several months without a response, I'm going to go ahead and close this. If/when you come back to this, feel free to open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3362 I have tried to add basic argument ordering to
clap_man. To do this I had to reach up into the mainclapcrate, to expose the methodget_display_order().The added code is currently quite verbose because I am printing the
--helpargument first, and then printing the remaining arguments in order which has resulted in some duplication... This ordering makes sense to me but might not be the style wanted. I have also added a unit test to verify that the arguments appear in the desired order in both the Synopsis and Options sections of the manual.