feat(derive): Allow users to opt-in to ValueParser
#3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the aliasing is safe (the compiler says so!) but we're going to be switching to a `&mut` and need to ensure we don't alias.
In case the `ArgMatches` is cloned, this forces a constraint that the underlying type impls `Clone` but that should be safe as we only support `String` and `OsString`.
For clap 3, its opt-in as a precaution against breaking compatibility in some weird cases. This does require the types to implement `Clone`. Fixes clap-rs#3734 Fixes clap-rs#3496 Fixes clap-rs#3589
Only bothered to implement this for `value_parser` cases as `parse` cases are going to be considered deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clap 3, its opt-in as a precaution against breaking
compatibility in some weird cases. We made this easy by just specifying
#[clap(value_parser)]which will default tovalue_parser(value_parser!(T)).This does require the types to implement
Clonesince theArcmight have copies made.In doing this, some bugs / inccompleteness of
value_parserwas observed and fixedDeprecations were deferred out of this to keep it smaller.
Fixes #3731
Fixes #3496
Fixes #3589