fix(docs): Update deprecations to latest target #3862
Merged
+38
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, I was mixed on doing this as ideally people would upgrade through the minor releases, going through the release notes. This also saves us havin to audit deprecations to make sure they are all pointing to the latest. First, this isn't practical for users. Its annoying to pin your version (at least its easier now that we pin `clap_derive` for users) and a lot of work to go through them one step at a time. On top of that, we've changed our deprecation policy to put the timing of responding to deprecations into the user's hands with, with us putting them behind the `deprecated` feature flag. This means someone might respond to deprecations every once in a while or might not do it until right before the 4.0 release. Our deprecation messages should be updated to respond to that. This supersedes clap-rs#3616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, I was mixed on doing this as ideally people would upgrade
through the minor releases, going through the release notes. This also
saves us havin to audit deprecations to make sure they are all pointing
to the latest.
First, this isn't practical for users. Its annoying to pin your version (at least
its easier now that we pin
clap_derivefor users) and a lot of work togo through them one step at a time.
On top of that, we've changed our deprecation policy to put the timing
of responding to deprecations into the user's hands with, with us
putting them behind the
deprecatedfeature flag. This means someonemight respond to deprecations every once in a while or might not do it
until right before the 4.0 release. Our deprecation messages should be
updated to respond to that.
This supersedes #3616