Allow for more than 256 occurrences of an argument.

[cstorey]

Hi,

I often use tools with xargs and the like, and it's entirely possible to end up with inhumanly long sets of parameters being passed to a command.

Without this fix, the library will panic with an arithmetic overflow in ArgMatcher#inc_occurrence_of when the 256th instance of the parameter is accounted for.

Thanks,

[yo-bot]

Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @Vinatorul (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Vinatorul]

Thank you for your contribution!
All looks good to me. Only one thing - we don't update changelog by ourselfs. We are using clog to generate it from commit messages.
Also, can you add yourself to Contributors.md list?
And the last one (really) - we are changing the licence from MIT to dual MIT/Apache 2. So, will you be so kind to accept it? Link to issue: #389

[cstorey]

Hi, thanks for the quick review!
I've backed out the Changelog update; and added myself to the contributors file.
I'll confirm the license in the other ticket.

Thanks!

[Vinatorul]

Thank you kindly! I will merge as soon as build finish.

[kbknapp]

Looks good to me too, and this is something I've been casually thinking about for a while so thanks! 👍 @homu r+

[homu]

📌 Commit f86a183 has been approved by kbknapp

[homu]

⌛ Testing commit f86a183 with merge 700db3f...

[homu]

☀️ Test successful - status

[kbknapp]

@cstorey thanks again, and based on your work here I've also added support up to u64::max values per arg as well 😉 Once #408 merges I'll put out v2.0.3 on crates.io!

[cstorey]

Thanks for your hard work!