Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace atty with is-terminal #4249

merged 1 commit into from Nov 24, 2022


Copy link

Not sure whether this would be something you'd want to have, but I'm a bit
unhappy with how widespread the atty crate is being used, because it both has a
soundness issue on Windows and
even though a well reviewed fix for that issue is available it hasn't been
merged, making it look like atty is unmaintained.

Luckily, someone has created a new crate which is re-using a lot of the code
from atty, but with the soundness issue fixed, which has a nice API as you can
tell here. My suggestion would be to switch to this instead.

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor Author

Updated this again to use is-terminal 0.4.0 and rebased on current master.

@epage epage merged commit fb1d960 into clap-rs:master Nov 24, 2022
21 checks passed
@jcgruenhage jcgruenhage deleted the replace-atty branch November 24, 2022 16:35
jpgrayson added a commit to stacked-git/stgit that referenced this pull request Nov 28, 2022
This follows suit with clap, which also changed to is-terminal, to
eliminate a redundant dependency and perhaps have a better maintained

Refs: clap-rs/clap#4249
etehtsea added a commit to etehtsea/spin that referenced this pull request Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants