fix(completion): emit value terminators on zsh #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose get_value_terminator() for use by clap_complete. Related-to: clap-rs#3022 Signed-off-by: David Aguilar <davvid@gmail.com>
Emit the user-defined value terminator into the zsh completion pattern
to avoid doubled rest-arguments definitions:
$ my-app <TAB>
_arguments:comparguments:325: doubled rest argument definition:
*::second -- second set of of multi-length arguments:
clap-rs#3266 (comment)
noted that including the value terminator is one step towards a
robust solution for handling multiple multi-valued arguments.
This change does not yet handle automatically detecting when a value
terminator is needed, but it does add tests to ensure that
user-specified value terminators are used on zsh.
Related-to: clap-rs#3022
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
to garden-rs/garden
that referenced
this pull request
Jan 21, 2023
Related-to: #10 Related-to: clap-rs/clap#3022 Related-to: clap-rs/clap#4624 Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
to garden-rs/garden
that referenced
this pull request
Jan 21, 2023
Now that clap-rs/clap#4624 was merged we can use value_terminator to fix the zsh completions for commands that use two consecutive multi-valued arguments. A more complete solution may arrive in clap-rs/clap#4612 but until that is merged we can use this solution for now. If that change is ever merged then we can bump our clap_complete version and remove our use of value_terminator. Related-to: #10 Related-to: clap-rs/clap#3022 Related-to: clap-rs/clap#4624 Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #4612