Export error constructors #5067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
export-error-constructors
branch
2 times, most recently
from
572157b
to
b6e6518
Compare
This exports the following `Error` constructors to improve diagnostic generation for `TypedValueParser` implementors: - `Error::empty_value` - `Error::invalid_value` - `Error::value_validation`
9999years
force-pushed
the
export-error-constructors
branch
from
b6e6518
to
8828030
Compare
9999years
force-pushed
the
export-error-constructors
branch
from
8828030
to
b09fa51
Compare
This enables downstream consumers to set custom error messages and take advantage of the `context` mechanism for annotating errors with the provided arguments and values. Fixes clap-rs#5065
9999years
force-pushed
the
export-error-constructors
branch
from
acbe4fb
to
b4b0c73
Compare
|
More investigation is needed before we can consider making these APIs public as they increase our compatibility burden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5065. This exports the following
Errorconstructors to improve diagnostic generation forTypedValueParserimplementors:Error::empty_valueError::invalid_valueError::value_validationAdditionally, this exports
Error::set_sourceto provide a mechanism for custom error messages while still taking advantage of thecontextformatting.Future work
Perhaps we should consider making public
Error::invalid_subcommand, though I have no use for it at the moment.