Issues 536 to 539 #540
Merged
Issues 536 to 539 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w correctly match <cmd> <sub> --help Prior to this fix, runnning `prog help subcmd` would produce: ``` subcmd USGAE: [...] ``` Notice lack of `prog-subcmd`. Whereas running `prog subcmd --help` produced: ``` prog-subcmd USGAE: [...] ``` These two forms now match the correct one (latter). Closes #539
… help message Previously, if one ran `<cmd> help help` an additional `help` subcommand was created and a help message displayed for it. We *could* have just thrown an error `<cmd> help help` but I worry that the message would be confusing, because something like, "Invalid Subcommand" isn't 100% correct as the form `<cmd> help <subcmd>` is allowed, and there *is* a `help` subcmd. This fix correct dispatches `<cmd> help help` to the `<cmd>` help message. Closes #538
…d to usage strings In usage strings `[FLAGS]` and `[ARGS]` tags are now only added if there are relevant flags and args to collapse. I.e. those that are * Not required (`[ARGS]` only) * Not belonging to some required group * Excludes --help and --version (`[FLAGS]` only) Closes #537
…een printed by `--help` or the like Using `App::print_help` before wasn't building the default `--help` and `--version` flags properly. This has now been fixed. Closes #536
|
r? @Vinatorul (yo-bot has picked a reviewer for you, use r? to override) |
|
@homu r+ |
|
📌 Commit e84cc01 has been approved by |
|
⚡ Test exempted - status |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.