Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved vulnerabilities #5496

Closed
wants to merge 1 commit into from
Closed

Solved vulnerabilities #5496

wants to merge 1 commit into from

Conversation

41Leahcim
Copy link

@epage
Copy link
Member

epage commented May 17, 2024

What is the motivation for this? These look to all be from dev-depedencies and our Cargo.lock has no affect on our dependents.

@41Leahcim
Copy link
Author

I wanted to contribute to the clap crate and when contributing I first check for vulnerabilities with cargo audit. In this case I found some vulnerabilities which could easily be solved with cargo update. I know it doesn't affect dependents, but I don't think that should be a reason not to update your Cargo.lock file when it contains vulnerable (versions of) dependencies.

@epage
Copy link
Member

epage commented May 19, 2024

I generally prefer to keep the lockfile low and these vulnerabilities don't affect us, so I would rather close this.

@epage epage closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants