fix(fish completions): quote short options too #5503
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should make things a bit easier for any programs that want to make '-?' an alias for '--help' this is a bit more complex than initially anticipated, since the unit tests expect output to be bit-identical.
|
Can you add a test case that demonstrates the problem? Ideally, the test case would apply to all shells and be in its own commit, showing the current behavior. Your current commit would then be on top and would then include test updates. Separating the test from the fix makes it so the fix commit demonstrates in action what the change of behavior is and helps test-the-test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should make things a bit easier for any programs that want to make '-?' an alias for '--help'