Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues 625,626 #628

Merged
merged 7 commits into from
Aug 25, 2016
Merged

Issues 625,626 #628

merged 7 commits into from
Aug 25, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Aug 25, 2016

No description provided.

@kbknapp
feat(Help): adds new short hand way to use source formatting and igno…
7dfdaf2 
…re term width in help messages

Prior to this commit if one wished to use source formatting and ignore
term width they could do `App::set_term_width(usize::MAX)` now one can
also use `App::set_term_width(0)` which does the same thing.

Closes #625
@kbknapp
tests: adds tests for ignoring term width with set_term_width(0)
7558261
@kbknapp
docs(Term Width): adds details about set_term_width(0)
00b8205
@kbknapp
tests: adds tests to prevent issue 626
881a647
@kbknapp
fix(Unicode): fixes two bugs where non-English characters were stripp…
763a5c9 
…ed or caused a panic with help wrapping

Closes #626
@yo-bot
Copy link

yo-bot commented Aug 25, 2016

r? @sru

(yo-bot has picked a reviewer for you, use r? to override)

@kbknapp kbknapp mentioned this pull request Aug 25, 2016
Closed
@kbknapp kbknapp mentioned this pull request Aug 25, 2016
Closed
@kbknapp
Copy link
Member Author

kbknapp commented Aug 25, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Aug 25, 2016

📌 Commit 57690b2 has been approved by kbknapp

homu added a commit that referenced this pull request Aug 25, 2016
@homu
Auto merge of #628 - kbknapp:issues-625,626, r=kbknapp
8166f23 
Issues 625,626
homu added a commit that referenced this pull request Aug 25, 2016
@homu
Auto merge of #628 - kbknapp:issues-625,626, r=kbknapp
bd704e0 
Issues 625,626
@homu
Copy link
Contributor

homu commented Aug 25, 2016

⌛ Testing commit 57690b2 with merge bd704e0...

@homu
Copy link
Contributor

homu commented Aug 25, 2016

☀️ Test successful - status

@homu homu merged commit 57690b2 into master Aug 25, 2016
@kbknapp kbknapp deleted the issues-625,626 branch August 26, 2016 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sru sru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbknapp @yo-bot @homu @sru