Add no_cargo feature to disable Cargo-env-var-dependent macros #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
commented
Dec 27, 2016
| a.p.meta.author = Some(crate_authors!()); | ||
| a.p.meta.version = Some(crate_version!()); | ||
| a.p.meta.author = Some("Kevin K. <kbknapp@gmail.com>"); | ||
| a.p.meta.version = Some("2.19.2"); |
There was a problem hiding this comment.
Set these values to what they'd evaluate to anyway, BTW.
|
?r @kbknapp Paging @acmcarther, too, because he requested the feature |
nabijaczleweli
changed the title
|
Excellent! I hadn't thought of doing the reverse (the feature removes something), that's a mistake on my part. For the 3.x changes I'd still like to make this feature additive, but for now this works great. |
|
This is great! Yes, actually what I'd had in mind was something like this, but I figured I could wait for whatever form would be most appropriate for this project. Thanks @nabijaczleweli! |
|
@homu r+ |
|
📌 Commit 907bba5 has been approved by |
homu
added a commit
that referenced
this pull request
Dec 27, 2016
Add no_cargo feature to disable Cargo-env-var-dependent macros
For example, given:
```toml
clap = { path = "t:/clap-rs" }
```
The macros `crate_version!()` and `crate_authors!()` exist, so the crate compiles without errors:
```
Compiling https v0.2.0 (file:///P:/Rust/http)
Finished debug [unoptimized + debuginfo] target(s) in 6.93 secs
Finished debug [unoptimized + debuginfo] target(s) in 0.0 secs
[Finished in 7.5s]
```
But, adding the `no_cargo` feature:
```toml
clap = { path = "t:/clap-rs", features = ["no_cargo"] }
```
The macros are removed, so the crate fails to compile:
```
Compiling clap v2.19.2 (file:///T:/clap-rs)
Compiling https v0.2.0 (file:///P:/Rust/http)
error: macro undefined: 'crate_version!'
--> src\options.rs:40:22
|
40 | .version(crate_version!())
| ^^^^^^^^^^^^^
error: macro undefined: 'crate_authors!'
--> src\options.rs:41:21
|
41 | .author(crate_authors!())
| ^^^^^^^^^^^^^
error: aborting due to 2 previous errors
error: Could not compile `https`.
```
Closes #783
homu
added a commit
that referenced
this pull request
Dec 27, 2016
Add no_cargo feature to disable Cargo-env-var-dependent macros
For example, given:
```toml
clap = { path = "t:/clap-rs" }
```
The macros `crate_version!()` and `crate_authors!()` exist, so the crate compiles without errors:
```
Compiling https v0.2.0 (file:///P:/Rust/http)
Finished debug [unoptimized + debuginfo] target(s) in 6.93 secs
Finished debug [unoptimized + debuginfo] target(s) in 0.0 secs
[Finished in 7.5s]
```
But, adding the `no_cargo` feature:
```toml
clap = { path = "t:/clap-rs", features = ["no_cargo"] }
```
The macros are removed, so the crate fails to compile:
```
Compiling clap v2.19.2 (file:///T:/clap-rs)
Compiling https v0.2.0 (file:///P:/Rust/http)
error: macro undefined: 'crate_version!'
--> src\options.rs:40:22
|
40 | .version(crate_version!())
| ^^^^^^^^^^^^^
error: macro undefined: 'crate_authors!'
--> src\options.rs:41:21
|
41 | .author(crate_authors!())
| ^^^^^^^^^^^^^
error: aborting due to 2 previous errors
error: Could not compile `https`.
```
Closes #783
|
☀️ Test successful - status |
|
👀 Test was successful, but fast-forwarding failed: 422 Required status check "coverage/coveralls" is pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, given:
The macros
crate_version!()andcrate_authors!()exist, so the crate compiles without errors:But, adding the
no_cargofeature:The macros are removed, so the crate fails to compile:
Closes #783