Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests - Increase test coverage for Events existent code #21

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Tests - Increase test coverage for Events existent code #21

merged 1 commit into from
Aug 19, 2020

Conversation

joaopaulovieira
Copy link
Member

Summary

This PR adds tests for existent code on events.js.

Changes

  • Add more tests for triggerEvents method;
  • Add more tests for once method;
  • Add more tests for off method;
  • Add more tests for trigger method;
  • Add more tests for stopListening method;
  • Add more tests for register method;
  • Add more tests for listAvailableCustomEvents method;
  • Add more tests for listenTo method;
  • Add more tests for listenToOnce method;

How to test

All changes in this PR should not impact any use of the Clappr.

@joaopaulovieira joaopaulovieira added the improvement A piece of code that does not change an existing feature. (e.g.: test addition) label Aug 1, 2020
@joaopaulovieira joaopaulovieira changed the title Test - increase test coverage for existent Events code Test - increase test coverage for Events existent code Aug 1, 2020
@joaopaulovieira joaopaulovieira changed the title Test - increase test coverage for Events existent code Tests - increase test coverage for Events existent code Aug 1, 2020
@joaopaulovieira joaopaulovieira changed the title Tests - increase test coverage for Events existent code Tests - Increase test coverage for Events existent code Aug 1, 2020
@towerz towerz merged commit 05371ba into master Aug 19, 2020
@towerz towerz deleted the test-coverage-events branch August 19, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@towerz towerz towerz approved these changes

@leandromoreira leandromoreira Awaiting requested review from leandromoreira

@luzeduardo luzeduardo Awaiting requested review from luzeduardo

@jhonatangcavalcanti jhonatangcavalcanti Awaiting requested review from jhonatangcavalcanti

Assignees
No one assigned
Labels
improvement A piece of code that does not change an existing feature. (e.g.: test addition)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaopaulovieira @towerz