New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
player.setVolume() does not updates the localStorage value #677
Comments
Because of this bug after loading new player the volume are changed to wrong value. |
Fix localstorage volume settings bug (fixes #677)
Version 0.2.22 still has this bug. As I can see there is no release yet. |
Version 0.2.47 still has this bug. It seems that the bug was brought back by c805ffa |
I see that there is no tests written. :D |
@FDiskas you are welcome to submit a PR and add proper tests if you wish. |
It's not my bussines |
On http://cdn.clappr.io/ website in console enter
localStorage
This will return the
{clappr.cdn.clappr.io.volume: "0"}
then enter
and then again
but if the volume is changed by pressing on volume control bar then localStorage returns
{clappr.cdn.clappr.io.volume: "56.02678571428571"}
The text was updated successfully, but these errors were encountered: