Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player.setVolume() does not updates the localStorage value #677

Closed
FDiskas opened this issue Nov 16, 2015 · 7 comments
Closed

player.setVolume() does not updates the localStorage value #677

FDiskas opened this issue Nov 16, 2015 · 7 comments
Assignees

Comments

@FDiskas
Copy link

FDiskas commented Nov 16, 2015

On http://cdn.clappr.io/ website in console enter

localStorage

This will return the

{clappr.cdn.clappr.io.volume: "0"}

then enter

player.setVolume(50);

and then again

localStorage;

but if the volume is changed by pressing on volume control bar then localStorage returns

{clappr.cdn.clappr.io.volume: "56.02678571428571"}
@FDiskas
Copy link
Author

FDiskas commented Nov 16, 2015

Because of this bug after loading new player the volume are changed to wrong value.

@dayvson
Copy link
Member

dayvson commented Nov 28, 2015

Hey @FDiskas I sent a pull request to fix this issue #701
After it gets merged could you please test it?

flavioribeiro added a commit that referenced this issue Nov 30, 2015
Fix localstorage volume settings bug (fixes #677)
@FDiskas
Copy link
Author

FDiskas commented Dec 1, 2015

Version 0.2.22 still has this bug. As I can see there is no release yet.
p.s. I'm testing on http://cdn.clappr.io/

@gamtiq
Copy link
Contributor

gamtiq commented Apr 13, 2016

Version 0.2.47 still has this bug. It seems that the bug was brought back by c805ffa

@FDiskas
Copy link
Author

FDiskas commented Apr 13, 2016

I see that there is no tests written. :D
736138a
So why we returning to the same bug twice?

@towerz
Copy link
Member

towerz commented Apr 13, 2016

@FDiskas you are welcome to submit a PR and add proper tests if you wish.

@FDiskas
Copy link
Author

FDiskas commented Apr 13, 2016

It's not my bussines

@clappr clappr locked and limited conversation to collaborators Apr 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants