Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to render a poster before video playback #8

Closed
flavioribeiro opened this issue Feb 24, 2014 · 2 comments
Closed

Should be able to render a poster before video playback #8

flavioribeiro opened this issue Feb 24, 2014 · 2 comments
Labels
feature plugin

Comments

@flavioribeiro
Copy link
Member

No description provided.

thiagopnts pushed a commit that referenced this issue Feb 24, 2014
basic implementation for the poster plugin(refs #8)
07fd5cc
@thiagopnts
Copy link
Member

We need to know where the poster comes from:
https://github.com/globoi/player/blob/07fd5cc6e0ea9bf267086494e497c36b68378916/src/components/playback_handler.js#L34

This is not right, this should be removed after finishing the container's base css. This kind of decision must be done based on z-index:
https://github.com/globoi/player/blob/07fd5cc6e0ea9bf267086494e497c36b68378916/src/plugins/html5_video_playback.js#L21-L28

@flavioribeiro
Copy link
Member Author

it needs to receive poster option on embed

jhonatangcavalcanti pushed a commit that referenced this issue May 2, 2024
@towerz
Merge pull request #8 from clappr/dependabot/npm_and_yarn/lodash.merg…
f24f210 
…ewith-4.6.2

chore(deps): bump lodash.mergewith from 4.6.0 to 4.6.2
jhonatangcavalcanti added a commit that referenced this issue May 2, 2024
@jhonatangcavalcanti
Merge pull request #8 from clappr/overwrite-html5-methods
9a5fa9b 
 Overwrite HTML5Video inherited methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flavioribeiro @thiagopnts