Allow mocking of 'window' #1011

tjenkinson · 2016-05-31T20:58:30Z

Now that I've done this I'm wondering if it might actually make more sense not to have the "base\mocks" module and expect the developer to mock the global window variable when they run their tests instead?@clappr/core ?

This PR allows

var Clappr = require("clappr");
Clappr.mocks.window = myFakeWindow;

var player = new Clappr.Player() //etc

And document with "mocks.window.document", navigator with "mocks.window.navigator". Refs #1003

tjenkinson · 2016-05-31T20:59:33Z

src/base/utils.js

@@ -195,23 +196,31 @@ export function isNumber(value) {
 }

 export function currentScriptUrl() {


Need to figure out how to do this before this. It needs to be called in the same tick as the script being loaded, but can't be called before the developer has a chance to set their window :/

coveralls · 2016-05-31T21:14:07Z

Coverage decreased (-0.5%) to 69.72% when pulling 6966729 on feat-mock-window into 8be7b95 on master.

tjenkinson · 2016-06-05T18:27:37Z

Think it makes more sense just to mock the browser completely than add this.

tjenkinson added 2 commits May 31, 2016 21:38

Create "mocks" and replace window with mocks.window

b2a0433

And document with "mocks.window.document", navigator with "mocks.window.navigator". Refs #1003

Added Mocks test

6966729

flavioribeiro added the in progress label May 31, 2016

tjenkinson reviewed May 31, 2016
View reviewed changes

tjenkinson closed this Jun 5, 2016

flavioribeiro removed the in progress label Jun 5, 2016

tjenkinson deleted the feat-mock-window branch July 2, 2016 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow mocking of 'window' #1011

Allow mocking of 'window' #1011

tjenkinson commented May 31, 2016 •

edited

tjenkinson May 31, 2016

coveralls commented May 31, 2016

tjenkinson commented Jun 5, 2016

		@@ -195,23 +196,31 @@ export function isNumber(value) {
		}

		export function currentScriptUrl() {

Allow mocking of 'window' #1011

Allow mocking of 'window' #1011

Conversation

tjenkinson commented May 31, 2016 • edited

tjenkinson May 31, 2016

Choose a reason for hiding this comment

coveralls commented May 31, 2016

tjenkinson commented Jun 5, 2016

tjenkinson commented May 31, 2016 •

edited