Match by lowercase extensions in "_canPlay" #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -408,6 +408,8 @@ export default class HTML5Video extends Playback { | |||
|
|
|||
| HTML5Video._canPlay = function(type, mimeTypesByExtension, resourceUrl, mimeType) { | |||
| var extension = (resourceUrl.split('?')[0].match(/.*\.(.*)$/) || [])[1] | |||
| extension = (extension || "").toLowerCase() | |||
|
|
|||
| var mimeTypes = mimeType || mimeTypesByExtension[extension] || [] | |||
There was a problem hiding this comment.
Hi @sjlu
Well spotted thanks for the PR.
I think changing this line to
var mimeTypes = mimeType || (extension && mimeTypesByExtension[extension.toLowerCase()]) || []would be better, because we shouldn't be trying to access mimeTypesByExtension[undefined]
|
@tjenkinson change made |
|
Thanks @sjlu! 🍻 |
|
Glad to be of help @towerz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the URL contains a uppercase character, it'll help match the mediaType list (e.g. "MP4" vs "mp4)