Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flexbox container layout issues on older browsers #1110

Merged
merged 2 commits into from Aug 9, 2016
Merged

Fix for flexbox container layout issues on older browsers #1110

merged 2 commits into from Aug 9, 2016

Conversation

michaelcunningham19
Copy link
Contributor

Confirmed affected browsers:
Internet Explorer 10
Safari on iOS 8.4 (iPad Air 2)

The container for the player poster did not have the Play button vertically aligned in the center.

Before:
https://www.dropbox.com/s/2hoae0yssccroc5/Screenshot%202016-08-08%2014.14.27.png?dl=0

After:
https://www.dropbox.com/s/ujv85f01xi75hzt/Screenshot%202016-08-08%2014.14.01.png?dl=0

When using flexbox with an older browser that implements an older version of the flexbox specification, prefixes must be added, in some cases, default values are different as well. See link:
https://msdn.microsoft.com/en-us/library/hh673531(v=vs.85).aspx

Prefixed values were generated with Autoprefixer: https://autoprefixer.github.io/

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 71.623% when pulling db69462 on michaelcunningham19:bugfix/poster-flexbox-prefixing into 1efbddf on clappr:master.

@tjenkinson
Copy link
Contributor

thanks @michaelcunningham19 :)

@clappr/core maybe we should use autoprefixer with webpack and have this be automatic?

@towerz
Copy link
Member

towerz commented Aug 9, 2016

@tjenkinson not really, we already use bourbon. We should use bourbon mixins, as we are already using on other plugins. This was only an oversight.

@michaelcunningham19 could you please update the PR using proper bourbon mixins instead of expanding the prefixes?

@michaelcunningham19
Copy link
Contributor Author

@towerz

I have updated the PR to use bourbon mixins 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.644% when pulling 62c1754 on michaelcunningham19:bugfix/poster-flexbox-prefixing into 1efbddf on clappr:master.

@towerz towerz merged commit 5795a09 into clappr:master Aug 9, 2016
@towerz
Copy link
Member

towerz commented Aug 9, 2016

Thanks, @michaelcunningham19! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants