Fix - Configure ignoring options when has source attribute #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation ignores the options object if it has a `source` or `sources` attribute. This will cause an incorrect behavior: when user want to reconfigure some options and load a new source (at the same time), this will not happen, because the configure method will ignore the options in favor of loading the source. This change will ensure that the two actions (load/configure) happen.
vagnervjs
changed the title
towerz
approved these changes
Feb 9, 2018
leandromoreira
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL/DR: The current implementation ignores the options object if it has a
sourceorsourcesattribute.This will cause an incorrect behavior: when user want to reconfigure some options and load a new source (at the same time), this will not happen, because the configure method will ignore the options in favor of loading the source.
This change will ensure that the two actions (load/configure) happen.