Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5 Video: Avoid empty source error on destroy #1612

Merged
merged 1 commit into from Mar 27, 2018
Merged

HTML5 Video: Avoid empty source error on destroy #1612

merged 1 commit into from Mar 27, 2018

Conversation

vagnervjs
Copy link
Member

Delete src attribute on destroy instead set empty source.
This change will avoid the following HTML5 Video error:
Code: 4, MEDIA_ELEMENT_ERROR: Empty src attribute

screen shot 2018-03-27 at 5 43 42 pm

@vagnervjs
html5_video: delete src attribute on destroy instead set empty source
6e7209a 
Avoid HTML5 Video error: "Code 4: MEDIA_ELEMENT_ERROR: Empty src attribute"
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 76.31% when pulling 6e7209a on vagnervjs:fix/playback-destroy into 147867b on clappr:master.

@towerz towerz merged commit 049b44d into clappr:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@towerz towerz towerz approved these changes

@joaopaulovieira joaopaulovieira joaopaulovieira approved these changes

@leandromoreira leandromoreira Awaiting requested review from leandromoreira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vagnervjs @coveralls @towerz @joaopaulovieira