Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case insenstive check for HLS playback #1718

Merged
merged 4 commits into from
Nov 12, 2018

Conversation

leandromoreira
Copy link
Member

@leandromoreira leandromoreira commented Oct 18, 2018

It fixes #1522

@coveralls
Copy link

coveralls commented Oct 18, 2018

Coverage Status

Coverage decreased (-0.5%) to 77.945% when pulling 592262b on mimetypes-case-sensitive-1522 into e55c8fe on master.

@leandromoreira
Copy link
Member Author

leandromoreira commented Oct 18, 2018

the build is passing locally =/
screen shot 2018-10-18 at 11 14 11 am

Chromium 62.0.3202 (Ubuntu 0.0.0) ERROR
  {
    "message": "Uncaught AssertionError: expected false to be true\nat node_modules/chai/chai.js:239:7\n\nAssertionError: expected false to be true\n    at test/playbacks/html5_video_spec.js:5030:27\n    at setResult (test/playbacks/html5_video_spec.js:823:71717)\n    at test/playbacks/html5_video_spec.js:823:71257",
    "str": "Uncaught AssertionError: expected false to be true\nat node_modules/chai/chai.js:239:7\n\nAssertionError: expected false to be true\n    at test/playbacks/html5_video_spec.js:5030:27\n    at setResult (test/playbacks/html5_video_spec.js:823:71717)\n    at test/playbacks/html5_video_spec.js:823:71257"
  }

Firefox 62.0.0 (Linux 0.0.0) HLS playback can play regardless of any mime type letter case FAILED
	expected false to be true
	AssertionError@base/node_modules/chai/chai.js?40e7aa72e9665366bfd82579520de4fb0754dfae:9320:13
	[3]</module.exports/Assertion.prototype.assert@base/node_modules/chai/chai.js?40e7aa72e9665366bfd82579520de4fb0754dfae:239:13
	[5]</module.exports/<@base/node_modules/chai/chai.js?40e7aa72e9665366bfd82579520de4fb0754dfae:1020:5
	propertyGetter@base/node_modules/chai/chai.js?40e7aa72e9665366bfd82579520de4fb0754dfae:7784:22
	proxyGetter@base/node_modules/chai/chai.js?40e7aa72e9665366bfd82579520de4fb0754dfae:9128:14
	@base/test/playbacks/hls_spec.js?133d39286f4675f45c2874b70d94d70b31cbb23a:24539:5

My firefox is 62.0.3 (macosx) though. It seems something related to chaijs

Copy link
Member

@towerz towerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leandromoreira I changed the travis configuration to use Chrome instead of Chromium. The problem with the tests seems to be related to running on an earlier version of Chrome/Chromium. Please rebase the branch to fix the PR checks.

@towerz towerz force-pushed the mimetypes-case-sensitive-1522 branch from 4690723 to 592262b Compare October 24, 2018 02:49
@towerz
Copy link
Member

towerz commented Oct 24, 2018

@leandromoreira I took the liberty of removing some duplicate commits coming from another PR. The test is still failing, I'm not sure why.
I'll have a better look at this tomorrow, since I cannot reproduce the failure on either my Mac or Windows machines, so I'll have to run them on Linux and see whether I can find out what's going on.

@towerz towerz merged commit c3d7576 into master Nov 12, 2018
@towerz towerz deleted the mimetypes-case-sensitive-1522 branch June 16, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants