Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logrotation should be defined #50

Closed
mrh666 opened this issue Dec 17, 2015 · 3 comments
Closed

Logrotation should be defined #50

mrh666 opened this issue Dec 17, 2015 · 3 comments

Comments

@mrh666
Copy link
Contributor

mrh666 commented Dec 17, 2015

Hi gdhbashton,

I figured out that debug level generates about 20Mb logs daily which is a lot...
So I defined logrotation for module, please check my 3 pull requests (tested, working)

@gdhbashton
Copy link
Contributor

Hi,

Apologies for a long delay on replying here - can you make the logrotate an optional feature?

e.g. I notice that the postrotate command is /sbin/service which is classically CentOS/RHEL6 - I'm trying to keep the module open for CentOS/RHEL7 as well as Debian / Ubuntu.

@mrh666
Copy link
Contributor Author

mrh666 commented Jan 19, 2016

gdhbashton, of course! I wrote it as an option in first place:
$logrotate_on should be "true" to turn it on. And by default it's "false".

About service/systemctl command you are right. I defined case for SysV/Systemd for Centos/Rhel/Scientific/Oracle 6,7 and Amazon Linux.
I tested it on Centos 6/7 and Amazon, I just don't have any other OSs in our environment. Changes in pull request applied.

@gdhbashton
Copy link
Contributor

CentOS is good enough for me right now - and thanks for pointing out the default false - so no breakage should occur.

That's merged to master now - thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants