Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#123 [Azure] CosmosDB capacity (RUs usage) detector #163

Merged
merged 1 commit into from
Nov 12, 2020
Merged

#123 [Azure] CosmosDB capacity (RUs usage) detector #163

merged 1 commit into from
Nov 12, 2020

Conversation

Shr3ps
Copy link
Member

@Shr3ps Shr3ps commented Oct 26, 2020

No description provided.

xp-1000
xp-1000 approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of using uppercase (RU) in variables names but it looks good thanks.

@xp-1000 xp-1000 added detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors) labels Oct 26, 2020
@xp-1000 xp-1000 added this to In progress in Claranet via automation Oct 26, 2020
@xp-1000 xp-1000 added this to the v0.3.0 milestone Oct 26, 2020
@xp-1000 xp-1000 linked an issue Oct 26, 2020 that may be closed by this pull request
Cloud Azure - Capacity detectors #123
Closed
@Shr3ps
Copy link
Member Author

Shr3ps commented Oct 26, 2020

I am not a big fan of using uppercase (RU) in variables names but it looks good thanks.

I will plan to make some deeper tests by the end of the week, and yes I will lower variables (I kept what was initially generated by the template j2 ;) )

@Shr3ps Shr3ps self-assigned this Oct 26, 2020
@xp-1000
Copy link
Contributor

xp-1000 commented Oct 26, 2020

I am not a big fan of using uppercase (RU) in variables names but it looks good thanks.

I will plan to make some deeper tests by the end of the week, and yes I will lower variables (I kept what was initially generated by the template j2 ;) )

good input I will take care of that.

@xp-1000 xp-1000 modified the milestones: v0.3.0, v1.0.0 Oct 26, 2020
@Shr3ps Shr3ps force-pushed the capa_azure_cosmos_detectors branch 3 times, most recently from ca16167 to a37fb13 Compare October 28, 2020 09:10
@xp-1000 xp-1000 force-pushed the master branch 2 times, most recently from e3c908a to d7c2d74 Compare November 2, 2020 11:55
@xp-1000 xp-1000 added new feature Request for new feature and removed enhancement Enhancement of existing (templating or detectors) labels Nov 2, 2020
@xp-1000 xp-1000 merged commit df442d1 into master Nov 12, 2020
Claranet automation moved this from In progress to Done Nov 12, 2020
@xp-1000 xp-1000 deleted the capa_azure_cosmos_detectors branch November 12, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xp-1000 xp-1000 xp-1000 approved these changes

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

Assignees

@Shr3ps Shr3ps

Labels
detectors About nex or existing detectors new feature Request for new feature
Projects
Claranet
Done
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Cloud Azure - Capacity detectors
2 participants
@Shr3ps @xp-1000