rabbitmq: use default aggregation by broker name #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xp-1000
approved these changes
Nov 5, 2020
xp-1000
force-pushed
the
aggregate_rabbitmq
branch
from
b6153ba
to
1eb3bfd
Compare
xp-1000
added
detectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using in cluster mode, metrics on node are gathered from the API which send metrics for every broker in the cluster. Meaning that for a cluster of 3 nodes, I will have the 3 node metrics gathered on each node (9 metrics instead of 3). I think it is better to aggregate per broker name (which is unique in a cluster) to avoid this.