Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regex instead of replace to only split on first : in filter #187

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Use regex instead of replace to only split on first : in filter #187

merged 1 commit into from
Nov 25, 2020

Conversation

maxenced
Copy link
Contributor

fix #186

The use of regex to match only first : avoid to split extra part of string.

xp-1000
xp-1000 suggested changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems you miss something in the excludes version

common/filter-tags/locals.tf Outdated Show resolved Hide resolved
xp-1000
xp-1000 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good for me thanks for that!

@xp-1000 xp-1000 merged commit 252481f into master Nov 25, 2020
@xp-1000 xp-1000 deleted the fix_double_dots_in_filter branch November 25, 2020 17:53
@xp-1000 xp-1000 added detectors About nex or existing detectors enhancement Enhancement of existing (templating or detectors) labels Feb 22, 2021
@xp-1000 xp-1000 added this to In progress in Claranet via automation Feb 22, 2021
@xp-1000 xp-1000 added this to the v0.4.0 milestone Feb 22, 2021
@xp-1000 xp-1000 added bug Something isn't working and removed enhancement Enhancement of existing (templating or detectors) labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xp-1000 xp-1000 xp-1000 approved these changes

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

Assignees
No one assigned
Labels
bug Something isn't working detectors About nex or existing detectors
Projects
Claranet
In progress
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

filter-tags variables should only split first ":"
2 participants
@maxenced @xp-1000