add teams common variable

[frederic-peraud]

This PR adds Teams as a common parameter. It allows to link detector(s) to Sfx Teams.

https://registry.terraform.io/providers/splunk-terraform/signalfx/latest/docs/resources/detector#teams

[xp-1000]

thanks @frederic-peraud

I pushed atomic commits to detail all steps to make this kind of change:

• add the variable declaration, this is what you already did. it will be obviously more painful if it should be declared at detector level.
• manually edit all "handmade" detectors tf files (no -gen in names) to use the variable. I use a crappy bash command for that: find -type f -name 'detectors-*.tf' ! -name 'detectors-gen.tf' -exec sed -E -i -r 's/^( *name *= format.*)$/\1\n\n toto = var.toto/' {} \; it will add toto definition to all detectors (not generated). aae48b4 (#239)
• then you will have to update the jinj2 template generator to add this definition, it is generally easy except that we have to be careful on keep a rendered output terraform fmt-ed in all scenarios (depending on yaml conf). 909b442 (#239)
• Finally run make update-module to let the generator do the job for the rest of files: 83af1ad (#239)

the value assigned to teams attribute and the last commit propose to :

• take the authorized_writer_teams value if it is defined but not teams
• take the teams value only if defined (not matter if authorized_writer_teams is defined or not).

It is only a proposition, if you disagree simply reset the last commit and update the definition of teams in all detectors (and the generator) to simply use the teams variable (remove try, coalescelist and authorized_writer_teams)

for now, nobody uses existing authorized_writer_teams which could also interest you and obviously you will be the first user of teams so please challenge this proposition to try to propose something which could help the user but keeping safe and with sens.

when it is ok for you please "publish" the draft PR to warn code owners they can review/approve this.

[frederic-peraud]

Hi @xp-1000

Your suggestions are ok for me and my team.