Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding vars to allow to disable detector in generator mode #244

Merged
merged 1 commit into from
Feb 9, 2021
Merged

adding vars to allow to disable detector in generator mode #244

merged 1 commit into from
Feb 9, 2021

Conversation

nicolasvion
Copy link
Contributor

  • adding vars to allow to disable detector in generator mode
  • removing trailing spaces

Shr3ps
Shr3ps requested changes Feb 3, 2021
View reviewed changes
scripts/templates/variables.tf.j2 Outdated Show resolved Hide resolved
xp-1000
xp-1000 suggested changes Feb 3, 2021
View reviewed changes
scripts/templates/values.yaml Outdated Show resolved Hide resolved
scripts/templates/variables.tf.j2 Outdated Show resolved Hide resolved
xp-1000
xp-1000 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thanks!

@xp-1000 xp-1000 merged commit ca40e67 into master Feb 9, 2021
@xp-1000 xp-1000 deleted the disabled_detectors_vars branch February 9, 2021 21:55
@xp-1000 xp-1000 self-assigned this Feb 22, 2021
@xp-1000 xp-1000 added new feature Request for new feature templating About modules templating or terraform capabilities labels Feb 22, 2021
@xp-1000 xp-1000 added this to the v1.2.0 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shr3ps Shr3ps Shr3ps approved these changes

@xp-1000 xp-1000 xp-1000 approved these changes

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

Assignees

@xp-1000 xp-1000

Labels
new feature Request for new feature templating About modules templating or terraform capabilities
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasvion @Shr3ps @xp-1000