init blob detectors - disabled by default, need explicit activation #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolasvion
commented
Feb 11, 2021
nicolasvion
commented
- adding blob storage detectors
- disabled by default, need explicit activation because of some stability pb
- customers' request
nicolasvion
requested review from
BzSpi,
cvauvarin,
Shr3ps and
xp-1000
as code owners
Shr3ps
requested changes
Feb 11, 2021
modules/integration_azure-storage-account-blob/conf/01-requests-rate-status.yaml
Outdated
Show resolved
Hide resolved
modules/integration_azure-storage-account-blob/conf/02-latency-e2e.yaml
Outdated
Show resolved
Hide resolved
nicolasvion
force-pushed
the
integration_azure-storage-account-blob
branch
2 times, most recently
from
eccd19f
to
fd0d32d
Compare
xp-1000
suggested changes
Feb 17, 2021
modules/integration_azure-storage-account-blob/common-modules.tf
Outdated
Show resolved
Hide resolved
nicolasvion
force-pushed
the
integration_azure-storage-account-blob
branch
from
3febceb
to
7b7219b
Compare
Shr3ps
approved these changes
Feb 18, 2021
- init blob detectors - disabled by default, need explicit activation and fixing all requested part - adding notes and fixing file name
xp-1000
force-pushed
the
integration_azure-storage-account-blob
branch
from
7b7219b
to
2e16e1a
Compare
xp-1000
added
detectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.