Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure MariaDB detectors module #363

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Azure MariaDB detectors module #363

merged 6 commits into from
Jan 5, 2022

Conversation

Shr3ps
Copy link
Member

@Shr3ps Shr3ps commented Dec 28, 2021

No description provided.

@Shr3ps Shr3ps added the detectors About nex or existing detectors label Dec 28, 2021
@Shr3ps Shr3ps linked an issue Dec 28, 2021 that may be closed by this pull request
[RFE] New module of detectors for Azure MariaDB #361
Closed
@Shr3ps Shr3ps changed the title Azure MariaDB detectors #361 Azure MariaDB detectors module Dec 28, 2021
xp-1000
xp-1000 approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, just some minor comments

modules/integration_azure-mariadb/conf/05-replication-lag.yaml Outdated Show resolved Hide resolved
modules/integration_azure-mariadb/conf/00-heartbeat.yaml Show resolved Hide resolved
modules/integration_azure-mariadb/conf/01-cpu.yaml Show resolved Hide resolved
Base automatically changed from azure_mysql_yaml_gen to master January 5, 2022 10:29
xp-1000
xp-1000 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we find other similar cases where 2 modules are almost the same we could find a way to handle that and limit the duplication. I think it is enough for now. thanks

@xp-1000 xp-1000 merged commit d32c2ea into master Jan 5, 2022
@xp-1000 xp-1000 deleted the azure_mariadb branch January 5, 2022 10:33
@xp-1000 xp-1000 added this to the v1.12.0 milestone Jan 5, 2022
@xp-1000 xp-1000 added this to In progress in Claranet via automation Jan 5, 2022
@xp-1000 xp-1000 added the new feature Request for new feature label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xp-1000 xp-1000 xp-1000 approved these changes

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

@tchernomax tchernomax Awaiting requested review from tchernomax tchernomax is a code owner

Assignees
No one assigned
Labels
detectors About nex or existing detectors new feature Request for new feature
Projects
Claranet
In progress
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

[RFE] New module of detectors for Azure MariaDB
2 participants
@Shr3ps @xp-1000