Wrong hitrate calculation for smart agent Redis #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aogereau
requested review from
BzSpi,
cvauvarin,
haedri,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Redis hitrate detector for smart_agent_redis uses the following formula
A / ( A + B )
Where both A and B have the same value ( derive.keyspace_hits ) which will always give a result of 50 % .
this fix will replace B by derive.keyspace_misses instead, (according to the official documentation : https://github.com/signalfx/signalfx-agent/blob/main/docs/monitors/collectd-redis.md ) , which will give the correct value for the redis hitrate