fix(aws-backup): avoid duplicated and ill-routed alerts #508
Conversation
NSenaud
requested review from
BzSpi,
cvauvarin,
haedri,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
NSenaud
changed the title
NSenaud
force-pushed
the
fix/aws-backup-missing-filtering
branch
from
c80107a
to
9b0770c
Compare
NSenaud
changed the title
NSenaud
force-pushed
the
fix/aws-backup-missing-filtering
branch
from
9b0770c
to
35b9d3d
Compare
NSenaud
force-pushed
the
fix/aws-backup-missing-filtering
branch
from
35b9d3d
to
62fafbf
Compare
| @@ -0,0 +1,3 @@ | |||
| variable "aws_account_id" { | |||
There was a problem hiding this comment.
I don't think forcing aws_account_id is a good idea, not everyone wants to filter by aws_account_id
It's best to let people choose if they want to by setting the appropriate filter in their own terraform
There was a problem hiding this comment.
Hello, we don't have much choice because recovery points are not automatically tagged according to the convention used with the detectors (see comment in common-filters.tf).
There was a problem hiding this comment.
Variable removed after further discussions.
| filters = format("filter('namespace', 'AWS/Backup') and filter('stat', 'sum') and filter('BackupVaultName', '*', match_missing=False) and filter('ResourceType', '*', match_missing=False) and filter('aws_account_id', '%s')", var.aws_account_id) |
There was a problem hiding this comment.
Aren't signals already filtered with most of these variables in the detector conf ?
There was a problem hiding this comment.
I have removed the filtering field in the detectors conf 👍
NSenaud
force-pushed
the
fix/aws-backup-missing-filtering
branch
from
4a89a21
to
a3918fe
Compare
No description provided.