Convert integration AWS ES to gen (+ improve rules in gen format) #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat : convert module integration_aws-elasticache-common to gen format feat : support for multiple signal in rules feat : support for multiple time the same severity in rules
haedri
requested review from
BzSpi,
cvauvarin,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
pdecat
reviewed
Nov 15, 2023
modules/integration_aws-elasticache-common/conf/02-max-connection.yaml
Outdated
Show resolved
Hide resolved
pdecat
reviewed
Nov 15, 2023
modules/integration_aws-elasticache-common/conf/06-evictions-growing.yaml
Outdated
Show resolved
Hide resolved
modules/integration_aws-elasticache-common/conf/05-free-memory.yaml
Outdated
Show resolved
Hide resolved
modules/integration_aws-elasticsearch/conf/07-ultrawarm-free-space.yaml
Outdated
Show resolved
Hide resolved
| warm_node_cpu: | ||
| metric: WarmCPUUtilization | ||
| signal: | ||
| formula: union(data_node_cpu, warm_node_cpu) |
There was a problem hiding this comment.
We should probably process those signals independently as Ultrawarm nodes do not have the same profile as normal nodes.
There was a problem hiding this comment.
It's a bit too much of a change for this PR, maybe for another one
JMHAUTBOIS-Claranet
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat : convert module integration_aws-elasticsearch to gen format
feat : convert module integration_aws-elasticache-common to gen format
feat : support for multiple signal in rules
feat : support for multiple time the same severity in rules
fixes #516