Merge pull request #59 from clarifynl/dev

Fix undefined array key 'ratio'
clarifynl · Nov 21, 2023 · f8f262f · f8f262f
2 parents ca08eea + 682ebba
commit f8f262f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "responsive-pics",
-  "version": "1.7.6",
+  "version": "1.7.7",
   "private": true,
   "scripts": {
     "bootstrap": "wpackio-scripts bootstrap",

diff --git a/responsive-pics.php b/responsive-pics.php
@@ -4,7 +4,7 @@
 	Plugin URI: https://responsive.pics
 	Description: Responsive Pics is a Wordpress tool for resizing images on the fly.
 	Author: Clarify (previously Booreiland)
-	Version: 1.7.6
+	Version: 1.7.7
 	Author URI: https://clarify.nl
 	Copyright: Wimer Hazenberg, Toine Kamps
 */
@@ -38,7 +38,7 @@ function __construct() {
 
 		// Variables
 		define('RESPONSIVE_PICS_DIR', plugin_dir_path(__FILE__));
-		define('RESPONSIVE_PICS_VERSION', '1.7.6');
+		define('RESPONSIVE_PICS_VERSION', '1.7.7');
 		define('RESPONSIVE_PICS_TEXTDOMAIN', 'responsive-pics');
 
 		// Init

diff --git a/src/class-responsive-pics.php b/src/class-responsive-pics.php
@@ -463,7 +463,7 @@ public static function get_picture($id = null, $sizes = null, $picture_classes =
 		$sources = isset($definition['sources']) ? $definition['sources'] : [];
 
 		foreach ($sources as $source) {
-			$data_aspectratio = $intrinsic ? ' data-aspectratio="' . $source['ratio'] . '"' : '';
+			$data_aspectratio = ($intrinsic && isset($source['ratio'])) ? ' data-aspectratio="' . $source['ratio'] . '"' : '';
 
 			if (isset($source['breakpoint'])) {
 				$urls = $source['source1x'];