Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI allows private components in group components but backend doesn't #35

Closed
twagoo opened this issue Apr 20, 2016 · 1 comment
Closed
Labels
Milestone

Comments

@twagoo
Copy link
Member

twagoo commented Apr 20, 2016

Transfered from Trac ticket #712


Create a private component and another component (or profile) that uses this component. Move the top level component to a group but not the referenced component. Go to the group and edit the component you just moved there. Save it.

The operation will not be successful and, unless there are other errors, messages like the following appear (one line per referenced private component):

Failed to register: - referenced component cannot be found in the appropriate registry components: clarin.eu:cr1:c_1407745712016 (group registry) 2
 - referenced component cannot be found in the appropriate registry components: clarin.eu:cr1:c_1407745712061 (group registry) 2
 - referenced component cannot be found in the appropriate registry components: clarin.eu:cr1:c_1407745712051 (group registry) 2
 - referenced component cannot be found in the appropriate registry components: clarin.eu:cr1:c_1407745712031 (group registry) 2
 - referenced component cannot be found in the appropriate registry components: clarin.eu:cr1:c_1407745712058 (group registry) 2

Notice that the editor allows dragging in private components and that the browser does not force the user to push the entire chain of private components when moving to a group. This should be made consistent (probably by not allowing mixed private/group hierarchies in the UI).

Reported by Alexander König (MPI-PL), verified in 1.14.1 at http://catalog.clarin.eu/ds/ComponentRegistry by twagoo.

@twagoo twagoo added this to the 2.1.0 milestone Apr 20, 2016
@twagoo twagoo added the bug label Apr 20, 2016
@twagoo
Copy link
Member Author

twagoo commented Apr 20, 2016

Solution can (should) be to not allow 'private' to be selected in components panel in editor

twagoo added a commit that referenced this issue Apr 21, 2016
…private) space when linking in components

Fixes #35
@twagoo twagoo closed this as completed Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant