Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the pop-up over a centre name, provide a link to that centre's info page #168

Closed
bansp opened this issue Oct 12, 2022 · 2 comments
Closed

In the pop-up over a centre name, provide a link to that centre's info page #168

bansp opened this issue Oct 12, 2022 · 2 comments
Assignees
@bansp
Labels
enhancement SIS:centres centre-oriented part of the SIS wontfix
Milestone
SIS v. 2.5.0

Comments

@bansp
Copy link
Member

bansp commented Oct 12, 2022 •
edited
Loading

As above.
This should go in tandem with #167 -- we need a global flag that shows whether a single centre is filtered. Then we don't need these popups but rather display centre information above the list. And when the flag is null, centre names get popups, and there is no "header" above the recommendations list.
@bansp bansp added this to the SIS v. 2.5.0 milestone Oct 13, 2022
@bansp bansp added the SIS:centres centre-oriented part of the SIS label Oct 13, 2022
@bansp bansp self-assigned this Feb 7, 2023
@bansp bansp added the homework stuff to think about actively between meetings label Feb 7, 2023
@bansp
Copy link
Member Author

bansp commented Feb 25, 2023

I must be in a reductionist mode / mood tonight, because this seems a bit overelaborate to me. I'd say, let's perhaps "nofix" this one and #167 . Maybe it's enough to simply provide link from centre names to centre info pages, everywhere we display centre names.

@bansp bansp added wontfix and removed homework stuff to think about actively between meetings labels Mar 21, 2023
@bansp
Copy link
Member Author

bansp commented Mar 21, 2023

It will be fixed together with #153 .

@bansp bansp closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bansp bansp

Labels
enhancement SIS:centres centre-oriented part of the SIS wontfix
Projects
None yet
Milestone
SIS v. 2.5.0
Development

No branches or pull requests
1 participant
@bansp