Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make base URL dynamic #248

Closed
margaretha opened this issue Dec 1, 2023 · 3 comments
Closed

Make base URL dynamic #248

margaretha opened this issue Dec 1, 2023 · 3 comments
Milestone
SIS v. 2.7.0

Comments

@margaretha
Copy link
Collaborator

Links in SIS are resolved with base-URL using the app:link method. The base URL is set within app.xql, that is not dynamic, whereas the base URL differs between the production instance and localhost.

URL resolving is not necessary anymore, so the links can be relative now.
@margaretha margaretha added this to the SIS v. 2.7.0 milestone Dec 1, 2023
@margaretha margaretha changed the title Get rid of base URL Make base URL dynamic Dec 19, 2023
@margaretha
Copy link
Collaborator Author

Relative URL doesn't work for menu, so we still need URL resolving.

@bansp
Copy link
Member

bansp commented Dec 21, 2023

Just to make sure: should we change anything at the bottom of page https://github.com/clarin-eric/standards/wiki/Installation
(which discusses base URL modifications?)

@margaretha
Copy link
Collaborator Author

Yes, it is not needed anymore. Thanks for the reminder!

mmatthiesencsc added a commit to CSCfi/Kielipankki-standards that referenced this issue Feb 15, 2024
@mmatthiesencsc @margaretha
KP-7936 Update FIN-CLARIN-recommendation.xml (#1)
f1792b8 
* Added domains of recommendations in centre pages (close clarin-eric#240)

* Implemented multiple curators (clarin-eric#238)

* Updated the style of multiple curators and added an example (clarin-eric#238)

* Make base URL semi dynamic (close clarin-eric#248)

* Added domains of recommendations in format pages (clarin-eric#240)

* addresses clarin-eric#238

* KP-7936 Update FIN-CLARIN-recommendation.xml

We went through all functional domains and added formats as we saw relevant. We skipped domains we deemed not relevant to Kielipankki.

* add jussi + stub for <info>

* make "centre" optional (for now) in the header - addresses clarin-eric#247 , change the former "centre" to "centreID" - references clarin-eric#249

* change "centre" to "centreID" in the filter field - addresses clarin-eric#249

* Fixed centreID.

* Added centre elements in recommendation files (clarin-eric#247)

* Updated references from filter/centre to filter/centreID (clarin-eric#249)

* Updated centre model to use recommendation files instead of centres.xml
(clarin-eric#247)

* Added SAW recommendation (clarin-eric#247)

* add "centreID" as an optional child of "format", with an annotation stating its purpose; see clarin-eric#249 (comment)

* KP-7936 add PDF for documentation, add review date

* KP-7936 remove PDF* for textual src lang data

* KP-7936 add info text based on Språkbanken

* KP-7936 Update FIN-CLARIN-recommendation.xml

We went through all functional domains and added formats as we saw relevant. We skipped domains we deemed not relevant to Kielipankki.

* add jussi + stub for <info>

* KP-7936 add PDF for documentation, add review date

* KP-7936 remove PDF* for textual src lang data

* KP-7936 add info text based on Språkbanken

* KP-7936 fix indent

---------

Co-authored-by: margaretha <margaretha@ids-mannheim.de>
Co-authored-by: piotr <piotr@bodysek>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SIS v. 2.7.0
Development

No branches or pull requests
2 participants
@bansp @margaretha